Add Python reprs (implemented in python)#1209
Closed
TomNicholas wants to merge 3 commits intoearth-mover:mainfrom
Closed
Add Python reprs (implemented in python)#1209TomNicholas wants to merge 3 commits intoearth-mover:mainfrom
TomNicholas wants to merge 3 commits intoearth-mover:mainfrom
Conversation
paraseba
reviewed
Sep 8, 2025
Collaborator
paraseba
left a comment
There was a problem hiding this comment.
I'm OK with this. But the reason why I'd prefer to write it in Rust is because of all the tests we would need if we do it in python. If we change the name read_only to readonly things break, in Rust we would get a compilation error.
4 tasks
Member
Author
That's fair. Closing this in favour of the rust implementation in #1217. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for how to close #1208.
With this we get
For compound classes I want to have them make nested repr calls, i.e.
Repository.__repr__includesRepositoryConfig.__repr__andStorage.__repr__, passed as "attributes". This way we should be able to have nice nested reprs for all classes be implemented simply and consistently. It should also be easy to change the reprs if necessary, or to match any API changes later.Then once that's done we can use the same approach but for HTML reprs in a follow-up PR.